ref(grouping): Use variant.contributes value in grouping info section
#100908
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100908 +/- ##
===========================================
- Coverage 81.15% 81.14% -0.01%
===========================================
Files 8617 8616 -1
Lines 382253 382241 -12
Branches 24031 24027 -4
===========================================
- Hits 310201 310177 -24
- Misses 71725 71737 +12
Partials 327 327 |
lobsterkatie
force-pushed
the
kmclb-use-variant-contributes-value-in-grouping-info-section
branch
from
9d3f6fa to
60f5c94
Compare
shayna-ch
approved these changes
Oct 3, 2025
lobsterkatie
deleted the
kmclb-use-variant-contributes-value-in-grouping-info-section
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #100893, which added a
contributesvalue to each variant in the grouping info JSON. In this PR, all of the places in the front end code where we've been using the presence of a hash value as a proxy for whether or not a variant contributes have been switched to use thecontributesvalue directly. This will let us control visibility of variants separately, without the side effects which come along with having or not having a hash value.